Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More than 10 tests in
com.huawei.dmestore.services.DmeAccessServiceImplTest
may fail due to the non-deterministic order of iteration ofHashMap
. Specifically, thetoJson()
used to convert theHashMap requestbody
into aJSONString
will iterate theHashMap
not necessarily in the order of that of putting elements.One can check the problem using NonDex :
Solution
Use
LinkedHashMap
instead ofHashMap
when initializing the variablerequestbody
so that it can be converted into aJSONString
as desired.