Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid expensive switching between integer and double types #178

Open
HughParsonage opened this issue Mar 23, 2019 · 0 comments
Open

Avoid expensive switching between integer and double types #178

HughParsonage opened this issue Mar 23, 2019 · 0 comments

Comments

@HughParsonage
Copy link
Owner

For various reasons (e.g. fidelity with the actual tax calculations which use integers, not fractional components; or because of conversion via Rcpp), there is quite a lot of conversion between integer types and double types in income_tax and model_income_tax. This slows down the computations a little and could potentially be avoided. See hutilscpp::pmaxC and friends for compatible versions which avoid the performance hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant