Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config should handle lower and upper case checks #79

Closed
hemz10 opened this issue Nov 20, 2023 · 4 comments
Closed

config should handle lower and upper case checks #79

hemz10 opened this issue Nov 20, 2023 · 4 comments
Labels
bug Something isn't working Ready for review Ready for review

Comments

@hemz10
Copy link
Contributor

hemz10 commented Nov 20, 2023

Overview

Currently the package accepts only lower case letters, when passing upper case it throws an error.

Steps to Reproduce

Steps to reproduce the behavior:
1.In the config json file give the chain name in upper case
2. Observe the output

Expected Behavior

It should internally convert to lower case and continue with execution. execution should not stop

Screenshots

image

@hemz10 hemz10 added the bug Something isn't working label Nov 20, 2023
@shanithkk
Copy link
Collaborator

Fixed in #122

@shanithkk shanithkk added the Ready for review Ready for review label Nov 28, 2023
@hemz10
Copy link
Contributor Author

hemz10 commented Nov 29, 2023

Issue is still reproducible.
image

@hemz10 hemz10 removed the Ready for review Ready for review label Nov 30, 2023
@riyaoayaw riyaoayaw added the Ready for review Ready for review label Jan 11, 2024
@Mr-Nobody21
Copy link
Contributor

Fixed in pr #176

@hemz10
Copy link
Contributor Author

hemz10 commented Jan 16, 2024

Closing this issue as fixed

@hemz10 hemz10 closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for review Ready for review
Projects
None yet
Development

No branches or pull requests

4 participants