-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding YT Playlists does not work #3
Comments
@appinteractive, I was thinking about taking this one after PR-19 gets merged. This is probably going to require me to change the RegEx again to include the playlist params, as well as the tests for all Youtube URLs. |
@MarcoBomfim same same in #34 you can fix both @MarcoBomfim it would be great to invest some research if there are existing solutions to this out there. Metaphor is not maintained and officially deprecated after all. So maybe we can add some library that does the parsing of youtube links for us? |
Regular expressions are hard to maintain. There is a saying: "As soon as you learn to solve a problem with a regular expression, you have another problem." |
Hey @roschaefer can we close this one? 😄 |
Hey @MarcoBomfim this repository along with the main one is not being maintained anymore. Development continues in https://github.com/Ocelot-Social-Community/Ocelot-Social. |
Thanks @roschaefer! I thought the project was discontinued, glad to read it is still going on. I might get back and do some contributing 💯 |
embedding a direct video works fine, embedding a playlist will mess up the link.
The text was updated successfully, but these errors were encountered: