Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer to a comment #200

Open
Mastercuber opened this issue Jul 11, 2018 · 9 comments
Open

Answer to a comment #200

Mastercuber opened this issue Jul 11, 2018 · 9 comments

Comments

@Mastercuber
Copy link

Mastercuber commented Jul 11, 2018

Is your feature request related to a problem? Please describe.
It is a bit weird when I answer to comment of a post and this answer is added at the end of the comment section as new comment.

Describe the solution you'd like
I think a better way to handle this is, to put all answers to one comment as a thread under the comment like in other social networks.

Describe alternatives you've considered

Additional context

@ghost
Copy link

ghost commented Jul 11, 2018

Hey @Mastercuber

thanks for the suggestion, if I remember correctly we already have that somewhere on the Todo list but with minor priority right now.

If you're able and willing to help and implement it feel free to create a PR.

Cheers,
Seb

@Mastercuber
Copy link
Author

Hey @sebako86

I never used backpack, vue templates cypress etc. before. But I do have some knowledge in npm, angular and angularjs, Javascript and Typescript. CSS (less, sass), HTML, Grunt, Browserify etc..

On monday I have my last exam, so after that I could see if I can handle that.

Cheers,
Armin

@ghost
Copy link

ghost commented Jul 11, 2018

Hey @Mastercuber ,

that's fine we can assist you and grow together. If you want feel free to join our discord dev channel here: https://discord.gg/NgVpvx9 and we will help you learn everything you don't know yet ;-)

All the best for your exam! 🥇

Cheers,
Seb

@Mastercuber
Copy link
Author

Hey @sebako86

Thanks for the discord link and the wishes :-). I will join the channel soon!

Cheers,
Armin

@roschaefer
Copy link
Contributor

Hi, I'm currently talking with @Mastercuber on discord. How deep should a nesting of comments be? E.g. Contribution >> Comment >> Reply. Or shall we have unlimited nesting?

I would favour a simple nesting (only comments and replies).

How should a possible implementation look like, shall we add a new model replies with a 1:m association to comments?

@appinteractive
Copy link
Member

I would do only one level nasting. Also would I use just a property like „replyedOnCommentId“ or a like on a standard comment.

@Mastercuber
Copy link
Author

Ok, first I will try to do it with a new property "replyedOnCommentId".

@appinteractive
Copy link
Member

Maybe „parentCommentId“ might be more generic. 😬

@Mastercuber
Copy link
Author

Mastercuber commented Aug 30, 2018

See this two PR's:
#231
Human-Connection/API#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants