Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment reply: Updated content only appears after page refresh #247

Open
sushidave opened this issue Sep 1, 2018 · 7 comments
Open

Comment reply: Updated content only appears after page refresh #247

sushidave opened this issue Sep 1, 2018 · 7 comments

Comments

@sushidave
Copy link

Describe the bug
After editing a comment reply the updated content is not instantly shown but only after a page refresh.

To Reproduce
Steps to reproduce the behavior:

  1. Edit the reply of a comment.
  2. Click on the 'Save Comment' button.
  3. Check the reply - the updated version does not appear.
  4. Refresh the page in the brower.
  5. The updated version appears.

Expected behavior
After saving the comment the updated version appears.

@appinteractive
Copy link
Member

Might be that we only listen to the comment create but not the comment update events.

@Lulalaby
Copy link
Contributor

Still a bug

@Gerald1614
Copy link

I looked at the code and the same issue appears when deleting a comment. in fact, in both cases, we do not commit our action and use mutation to change the state of the comment. so the vuex store is still in old state when the submit the change. the value only gets updated when at the reload because the store is populated from the API entirely.

@Gerald1614
Copy link

Hi, I could solve the issue. i still need to address same issue when deleting comment. i will add comments on discord and submit the code for revision soon

@roschaefer
Copy link
Contributor

@Gerald1614 that's amazing, you already joined our Discord Server? If not: https://discord.gg/6ub73U3

@Gerald1614
Copy link

yes, I did. i just do not know in which topics those things are discussed. I just also solved the issue with the delete part. let me know how you want me to proceed.

@roschaefer
Copy link
Contributor

@Gerald1614 great 👍 send us a work-in-progress pull request, so we can give you early feedback. Prefix the title with [WIP] and write into the description fix #247. This will link the PR with this issue. On Discord, you can write in chat-en or coding-en (for English).

Gerald1614 referenced this issue in Gerald1614/WebApp Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants