Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "read later" #42

Open
ionphractal opened this issue Mar 16, 2018 · 4 comments
Open

add "read later" #42

ionphractal opened this issue Mar 16, 2018 · 4 comments

Comments

@ionphractal
Copy link

When I browse HC, I sometimes see articles that sound interesting but I'm currently looking for something else. On other sites (i.e. youtube when I'm not logged in) I would just open another tab (which is kind of a workaround to me as my browser gets messy quickly). However, it is not even possible in HC to open a new tab with a post from the main screen (seems like STRG+click is disabled).

The requested feature is different from bookmarks as it represents a volatile list where entries are removed once read (if you want to keep them, bookmark them).

This is probably a larger feature and as a temporary workaround you could enable STRG+click.
I'm not a Vue expert, but it seems like
https://github.com/Human-Connection/WebApp/blob/develop/components/Contributions/ContributionCard.vue#L4
would be the place to add an additional system modifier key event?
https://vuejs.org/v2/guide/events.html#System-Modifier-Keys

@appinteractive
Copy link
Member

Hey @ionphractal, thanks for you input, the reason the key is not working is that we use the component from nuxt.js

Here we should change anyway as this is not a good idea for seo and / or accessbility.

@ionphractal
Copy link
Author

Great, thank you! Please let me know if you need anything else from me in this regard.

@appinteractive
Copy link
Member

You can now open contributions in new tabs as we are using plane a tags for the links. Just if you are interessted it looks like this: <a :href="this.$router.resolve('your/page/params').href">Linktext</a>

This also leads to an improved accessibility.

@ionphractal
Copy link
Author

@appinteractive Opening in new tabs works like charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants