Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dutch Language Support #683

Merged
merged 2 commits into from
Aug 13, 2023
Merged

feat: Dutch Language Support #683

merged 2 commits into from
Aug 13, 2023

Conversation

erikgeurts
Copy link
Contributor

First iteration

First iteration
@fuatakgun fuatakgun changed the title Translation into Dutch docs: Translation into Dutch Jul 26, 2023
@erikgeurts
Copy link
Contributor Author

Since this is my first attempt at contributing to this repository, I'd appreciate any tips you might have to fix the failing checks.

@cdnninja cdnninja changed the title docs: Translation into Dutch feat: Dutch Language Support Jul 26, 2023
@erikgeurts
Copy link
Contributor Author

My guess is that the problem stems from this:
image

@cdnninja
Copy link
Collaborator

My guess is that the problem stems from this: image

Could be! I removed codespell since it isn't helpful for non english. That leaves us with this as the key:

image

Any character you can swap that for to keep utf8?

@cdnninja
Copy link
Collaborator

Quick note I have also just moved most of the services details to the translation file so this will need to be done for the dutch file too.

@cdnninja
Copy link
Collaborator

Managed to convert to UTF 8 without loosing the character. This seems to have resolved. Thanks for the contribution!

@cdnninja cdnninja merged commit 79ba44b into Hyundai-Kia-Connect:master Aug 13, 2023
@erikgeurts
Copy link
Contributor Author

Quick note I have also just moved most of the services details to the translation file so this will need to be done for the dutch file too.

Ok, I will do that shortly.

I noticed a number of lines that are being repeated for each service (vehicle and selected vehicle). Might be an idea to make a generic entry for those lines and refer to them where you need them. Easier to maintain, less work for translators and less chance to make mistakes.

@cdnninja
Copy link
Collaborator

Do you know how we can do that using the home assistant spec? I know it can be done for select options but not sure on others. I am up for it if possible!

@fuatakgun
Copy link
Member

Can we refer to other strings?

https://developers.home-assistant.io/docs/internationalization/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants