-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Error · due to Content-length #457
Comments
Thanks for this @siwhitehouse . We'll want make sure that this email only gets sent once - we wouldn't want to email someone every day about this. Ideally, it would be a bit more nuanced than that, but we're looking at how we contact people more broadly within our work at ODS so I don't think it's worth building out any sort of complex system in the Registry.
I think this should just say 60MB, and
I think that "guidance on splitting activity files" is essential here - I had a conversation just yesterday about this and I don't think it's clear how this should be carried out. I may well have missed something, mind! |
Thanks @robredpath I've added some additional text to the specification:
This means that if an organisation amends an activity file to below the maximum file size they should again be notified if it subsequently goes back over, but they shouldn't get regular emails once they have breached. @cormachallinanderilinx can you propose how this email is triggered based on this specification, please? Searching the IATI Standard website led me to How To Create Your IATI Data Files, which only includes: "Please ensure your IATI XML files are less than 40MB. Larger IATI activity files can be split down into multiple sub-files e.g. split by country, region or date, with each activity contained in only one file." Which is not the specificity of advice I'd like us to be able to point to. |
This is less than the 60MiB, or 62914560B listed in the draft IATI data policy ("60MB" is ambiguous and could be used to mean either). But it's quite a bit more than the 40MB listed on https://iatistandard.org/en/guidance/publishing-data/creating-files/how-to-create-your-iati-data-files/ |
This is correct for the datastore, I'm not sure about D-Portal. |
@siwhitehouse should be able to tell from the package dict if there is already a content length error |
Thanks @Bjwebb What do you suggest we use in the email, please? cc @robredpath |
I could rewrite this as "This means your latest activity file will not appear in some IATI products, such as the IATI Datastore." |
Thanks @cormachallinanderilinx Does this work if there has been an error previously, the file has been successfully reduced in size below the maximum and then goes back over? |
Personally, I would increase the limit to 60MiB (62914560B), and then state that, as I think this would be the least likely to confuse people. You could say we suggest files should be less than 40MiB, but the registry enforces a hard limit of 60MiB to give some leeway. |
|
Agreed. I think we should just be straightforward and consistent. |
Thank you @Bjwebb @cormachallinanderilinx @robredpath We agreed to add this to the project and to mark it as ready. Having reviewed the issue I'm going to put it at the top of Proposed as we haven't resolved the question Rob raised about advice on splitting files. |
As a publisher,
I want to be informed via email when an activity file exceeds the maximum content-length
so that I can resolve the problem and have my activities appear in IATI products.
Acceptance criteria
When the Registry identifies that an activity file is too big and displays an error message on the data set page in the form:
then it should also send an email to the contact email address to inform them. This email should only be sent when an update takes an activity file from below the maximum file size to above it.
That email should be similar to:
where {dataset_name], {organisation}, {file_size} and {URL} are placeholder variables.
We need the following to be in a position to raise a pull request, please:
Also cc-ing @dan-odsc and @robredpath for info and comment
The text was updated successfully, but these errors were encountered: