Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Error and Exception handling needs fully designing #240

Open
hayfield opened this issue Nov 15, 2017 · 2 comments
Open

Error and Exception handling needs fully designing #240

hayfield opened this issue Nov 15, 2017 · 2 comments
Labels
enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). error-handling Relating to error handling. parent-issue An issue that makes reference to a number of other issues that split the large task into parts.

Comments

@hayfield
Copy link
Contributor

hayfield commented Nov 15, 2017

At present there are rudimentary attempts at error handling (and logging of what has happened). This needs improving to work more generally.

Current systems:

  • Exception objects with custom strings
  • Exception objects with no additional information
  • A base concept of iati.exceptions
  • ValidationErrorLog (for validation errors) - should this model be used elsewhere?
@hayfield hayfield added enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). error-handling Relating to error handling. labels Nov 15, 2017
@hayfield hayfield added the parent-issue An issue that makes reference to a number of other issues that split the large task into parts. label Nov 15, 2017
@allthatilk
Copy link
Contributor

Think the names of existing errors also needs a look at as part of this as err-not-iati-xml-missing-required-element is not fully reflective of all contexts in which it is raised.

@hayfield
Copy link
Contributor Author

Note: They're Validation errors, this issue is about the Python-language concept of Exceptions (dealt with via try-except.

...or at least it should be - looks like the last bullet needs re-wording!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). error-handling Relating to error handling. parent-issue An issue that makes reference to a number of other issues that split the large task into parts.
Projects
None yet
Development

No branches or pull requests

2 participants