Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should run in GitHub Actions against a local server (with and without Maintenance mode) #487

Open
ghost opened this issue Nov 21, 2024 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 21, 2024

Currently tests only run after deployment, against the relevant server. As this can't change whether Maintenance mode is on or not, only some of the tests run. Also, if there are any problems it's already deployed so it's to late.

It would be better if tests ran fully in GH actions, then we can test code before it's merged to main/develop. We can also test both with and without Maintenance mode.

It may be very difficult to fully set up test servers in GH actions tho, but we can look and see.

Could update readme so dev's are aware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants