Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression failure for scipy>1.8 #41

Open
IAlibay opened this issue Aug 7, 2022 · 1 comment
Open

Regression failure for scipy>1.8 #41

IAlibay opened this issue Aug 7, 2022 · 1 comment

Comments

@IAlibay
Copy link
Owner

IAlibay commented Aug 7, 2022 •
edited
Loading

The circmean & circvar methods have been changed in scipy, with the latter providing a normalised variance. Technically these now better reflect the way in which you calculate circular statistics, however this changes the weighting we had towards the combined variance (which in some ways highlights an issue with the maybe naive way in which we did things). This needs further investigation but I believe that the bond variance now has a greater contribution towards the summed variance.

For now we will pin to scipy<1.8, and then investigate how to move from here.
@ale94mleon
Copy link

Any news on this? SciPy is on v1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IAlibay @ale94mleon