Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Massive performance drop at edge of ship in March when LLL is enabled #132

Open
ajsglist opened this issue Jul 31, 2024 · 5 comments

Comments

@ajsglist
Copy link

Hey there,

I've finally managed to track down the mod causing major performance issues at the edge of the ship, and unfortunately it seems to be LLL. Currently using LLL 1.3.8, and when passing through the ship's load zone, massive performance issues are observed. When standing in this area, the performance issues persist. I've captured a few gifs to demonstrate the appreciable performance hit and attached them below.

Vanilla behavior (no mods): full 60fps as expected

https://i.imgur.com/YYtejbG.gif

Modded behavior w/ LLL (poolrooms): performance issues in this area

https://i.imgur.com/n2gQFpz.gif

Modded behavior w/ LLL (mantif): performance issues in this area

https://i.imgur.com/iSY3cbB.gif

Modded behavior w/o LLL (disabled): performance returns to vanilla levels, 60fps as expected

https://i.imgur.com/vb2WtkR.gif

Profile code: 019106ed-a6ce-ccee-d21c-427d61240d4d

Thanks!

@IAmBatby
Copy link
Owner

Initially due to the lack of performance comparisons with vanilla dungeons I'm going to suggest this is not directly due to LethalLevelLoader. In the base game the dungeons lack occlusion culling which may be a problem amplified by this particular area as well as more resource intensive dungeons. Have you tried using the mod Cull Factory to see if this resolves the issue?

@ajsglist
Copy link
Author

ajsglist commented Jul 31, 2024

Cull factory is included in the profile, yes.

Disabling LLL removes the performance issue (as demonstrated in the OP). The only apparent possibilities from the data provided are: LLL itself, LLL loading a problematic interior/moon erroneously (which I attempted to troubleshoot by loading different interiors), or a nasty mod conflict that only manifests on LLL's side (disabling other mods in the profile yielded no benefit)

edit: regarding cullfactory, it doesn't appear to be a GPU bottleneck (plenty of overhead). It's more likely an issue with the main cpu thread (I don't have any profiling tools available to delve deeper). Again, it's not simply ANY location causing this. It's the apparent load zone on the side of the ship.

edit 2: gif showing the performance issues disappear immediately upon exiting the area in question https://imgur.com/T9hstzp

@IAmBatby
Copy link
Owner

All four tests in the OP imply your performance is fine with vanilla interiors, and not fine with custom interiors, no?

@ajsglist
Copy link
Author

ajsglist commented Jul 31, 2024

No, the performance for the custom interiors is fine (again, there is no notable strain on the GPU from either vanilla interiors or custom interiors via LLL). The performance issue triggers at a reproducible distance from the ship consistent with "reentering" the ship (e.g. the distance at which ship mods traditionally cull/uncull themselves). The 5th gif (see post above) is taken a few feet further from the ship -- this gif also has a custom interior.

The issue persists with and without cullfactory. The only mod found to have any effect on the performance is disabling LLL itself, at which point performance in the "ship reentry zone" returns to a stable 60fps as expected.

edit: added quick markup to illustrate the issue more clearly
image

edit2: possibly an issue with the AudioReverbTriggers?

@ajsglist
Copy link
Author

ajsglist commented Aug 4, 2024

To be clear: the performance issues are also observed when LLL generates the default Facility interior. Do you have any insight into what's going on here and how it can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants