-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding changes for COS bucket backup #5794
Open
IBM-diksha
wants to merge
6
commits into
IBM-Cloud:master
Choose a base branch
from
IBM-diksha:diksha/f1887-dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinash1IBM
suggested changes
Nov 15, 2024
IBM-Deeksha
reviewed
Nov 18, 2024
IBM-Deeksha
approved these changes
Nov 18, 2024
avinash1IBM
suggested changes
Nov 18, 2024
IBM-Deeksha
approved these changes
Nov 19, 2024
avinash1IBM
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**DO NOT MERGE **
Regression result :
=== RUN TestAccIBMCosBackup_Vault_Create_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_Valid (32.85s)
=== RUN TestAccIBMCosBackup_Vault_Create_With_Activity_Tracking_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_With_Activity_Tracking_Valid (34.65s)
=== RUN TestAccIBMCosBackup_Vault_Create_With_Metrics_Monitoring_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_With_Metrics_Monitoring_Valid (32.06s)
=== RUN TestAccIBMCosBackup_Vault_Create_With_KP_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_With_KP_Valid (44.07s)
=== RUN TestAccIBMCosBackup_Vault_Create_With_AT_Enabled_MM_Disabled_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_With_AT_Enabled_MM_Disabled_Valid (31.07s)
=== RUN TestAccIBMCosBackup_Vault_Create_With_AT_Disabled_MM_Enabled_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_With_AT_Disabled_MM_Enabled_Valid (27.48s)
=== RUN TestAccIBMCosBackup_Vault_Create_Multiple_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_Multiple_Valid (29.00s)
=== RUN TestAccIBMCosBackup_Vault_Create_Multiple_Invalid
--- PASS: TestAccIBMCosBackup_Vault_Create_Multiple_Invalid (18.05s)
=== RUN TestAccIBMCosBackup_Vault_Create_All_Configurations_Valid
--- PASS: TestAccIBMCosBackup_Vault_Create_All_Configurations_Valid (32.26s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 284.733s
=== RUN TestAccIBMCosBackup_Policy_Basic_Valid
There is no lifecycle configuration on the bucket
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_Basic_Valid (44.43s)
=== RUN TestAccIBMCosBackup_Policy_BV_With_Activity_Tracking_Valid
There is no lifecycle configuration on the bucket
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_BV_With_Activity_Tracking_Valid (41.48s)
=== RUN TestAccIBMCosBackup_Policy_BV_With_Metrics_Monitoring_Valid
There is no lifecycle configuration on the bucket
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_BV_With_Metrics_Monitoring_Valid (35.59s)
=== RUN TestAccIBMCosBackup_Policy_BV_With_KP_Valid
There is no lifecycle configuration on the bucket
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_BV_With_KP_Valid (42.57s)
=== RUN TestAccIBMCosBackup_Policy_Multiple_Policy_Valid
There is no lifecycle configuration on the bucket
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_Multiple_Policy_Valid (33.82s)
=== RUN TestAccIBMCosBackup_Policy_Non_Versioning_Source_Bucket_Invalid
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_Non_Versioning_Source_Bucket_Invalid (33.39s)
=== RUN TestAccIBMCosBackup_Policy_Multiple_Invalid
There is no lifecycle configuration on the bucket
--- PASS: TestAccIBMCosBackup_Policy_Multiple_Invalid (20.18s)
=== RUN TestAccIBMCosBackup_Policy_Invalid_Backup_Type
--- PASS: TestAccIBMCosBackup_Policy_Invalid_Backup_Type (1.12s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 255.953s
=== RUN TestAccIBMCOSBackupPolicyDataSource_basic
--- PASS: TestAccIBMCOSBackupPolicyDataSource_basic (33.34s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 37.030s
--- PASS: TestAccIBMCOSBackupVaultDataSource_basic (31.84s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 35.177s