Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StorageClass Yamls to accept custom secrets #53

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

ashimagarg27
Copy link
Member

@ashimagarg27 ashimagarg27 commented Nov 21, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27 ashimagarg27 changed the title Update StorageClass Yamls to accept custom secrets and update operator limits Update StorageClass Yamls to accept custom secrets Nov 25, 2024
Signed-off-by: Ashima-Ashima1 <[email protected]>
Copy link
Collaborator

@Bhagyashreek8 Bhagyashreek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

bin/controller-gen Outdated Show resolved Hide resolved
config/default/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved
Copy link
Member

@nkkashyap nkkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashimagarg27 ashimagarg27 merged commit a00d372 into main Nov 26, 2024
1 check passed
@ashimagarg27 ashimagarg27 deleted the ashima branch November 26, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants