Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generic function stopRKey() in grid_benchmark_jobs.php stops legit CR events from triggering #5

Open
TheWitness opened this issue Sep 20, 2022 · 1 comment
Open

The generic function stopRKey() in grid_benchmark_jobs.php stops legit CR events from triggering #5

TheWitness opened this issue Sep 20, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@TheWitness
Copy link

Describe the bug

When editing the filter in grid_benchmark_jobs.php, you should be able to press the CR key and have the filter trigger. There is a function called stopRKey() that is used by RTM that is defective. It's only supposed to block the CR key from triggering on keypress when the "filter" is empty. This was due to a bug in browsers that when editing the filter form value, if you back-spaced when the string was empty, it could trigger a submit. However, this is coded incorrectly.

Step To Reproduce
Steps to reproduce the behavior:

  1. Edit the benchmark job results
  2. Type in some value into the filter
  3. Press Enter
  4. Note that the form callback does not trigger

Expected behavior

If the filter is null or not null and you press enter, the form should submit. If you press the backspace, and the filter is null, the submit should not trigger.
@TheWitness TheWitness added the bug Something isn't working label Sep 20, 2022
@TheWitness
Copy link
Author

This fix should be applied more broadly too.

sbuser-git added a commit to sbuser-git/ibm-spectrum-lsf-rtm-server that referenced this issue Sep 24, 2022
@sbuser-git
Update grid_benchmark_jobs.php
41a36ae 
Signed-off-by: Stephanie Buser [email protected]

Resolved IBM#4, IBM#5.

Signed-off-by: Stephanie Buser <[email protected]>
@ddb4github ddb4github mentioned this issue Oct 23, 2022
Merged
ddb4github pushed a commit that referenced this issue Jan 11, 2023
@sbuser-git
Fix for #4, #5, #6, #9 (#8), #10
828667d 
* Update grid_benchmark_jobs.php
  Resolved #4, #5.
* Update grid_functions.php
  Resolved #6.
* Update grid_benchmark_jobs.php
* Update grid_manage_hosts.php
  Issue #9
* Update ss_grid_jobs.php, ss_grid_slot_ut.php, ss_grid_effectiveut.php, ss_grid_lssched_bcs.php
* Update 
  patch that disables the query cache for the Cacti Data Collectors - #10

Signed-off-by: Stephanie Buser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheWitness