Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secrets from vendor kubernetes test files #22

Open
atantawi opened this issue Nov 15, 2022 · 1 comment
Open

Remove secrets from vendor kubernetes test files #22

atantawi opened this issue Nov 15, 2022 · 1 comment

Comments

@atantawi
Copy link
Member

commit vendored in some GCP BASE64 known secrets in https://github.com/ibm/kube-safe-scheduler

Found verified result 🐷🔑
Detector Type: GCP
Decoder Type: BASE64
Raw result: image-pulling@authenticated-image-pulling.iam.gserviceaccount.com
File: vendor/k8s.io/kubernetes/test/e2e/common/runtime.go
Timestamp: 2019-05-03 17:14:05 -0400 -0400
Line: 251
Link: https://github.com/ibm/kube-safe-scheduler/blob/15bd56e95b439420b32817ff04433c697a066e01/vendor/k8s.io/kubernetes/test/e2e/common/runtime.go
Repository: https://github.com/ibm/kube-safe-scheduler.git
Commit: 15bd56e

Found verified result 🐷🔑
Detector Type: GCP
Decoder Type: BASE64
Raw result: image-pulling@authenticated-image-pulling.iam.gserviceaccount.com
File: vendor/k8s.io/kubernetes/test/e2e_node/runtime_conformance_test.go
Timestamp: 2019-05-03 17:14:05 -0400 -0400
Line: 52
Link: https://github.com/ibm/kube-safe-scheduler/blob/15bd56e95b439420b32817ff04433c697a066e01/vendor/k8s.io/kubernetes/test/e2e_node/runtime_conformance_test.go
Repository: https://github.com/ibm/kube-safe-scheduler.git
Commit: 15bd56e

@atantawi
Copy link
Member Author

Delete following files from vendor directory:

  1. vendor/k8s.io/kubernetes/test/e2e/common/runtime.go
  2. vendor/k8s.io/kubernetes/test/e2e_node/runtime_conformance_test.go

Add note in readme for users to download such files in forked repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant