Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow link installation to VM Cluster #17

Closed
ilimit-devops opened this issue May 3, 2023 · 2 comments · Fixed by #29
Closed

Allow link installation to VM Cluster #17

ilimit-devops opened this issue May 3, 2023 · 2 comments · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@ilimit-devops
Copy link

Allow to link installations on "VM Cluster" objects, like "Kubernetes Cluster".

Deployments or StateFulSets are not VM, but reside in a "VM Cluster" (Kubernetes)

@MartVisser MartVisser added the enhancement New feature or request label Sep 18, 2023
@MartVisser
Copy link

Looks like a good idea to me.

A third type of link to 'Installations'. So adding 'Virtualization Clusters' (/virtualization/clusters/) in addition to 'Virtual Machines' and 'Devices'

@wkoot wkoot self-assigned this Sep 18, 2023
@wkoot
Copy link
Collaborator

wkoot commented Sep 22, 2023

Currently we have the property SoftwareProductInstallation.platform which is either a device virtualmachine.
The fact that the option is binary, is secretly used in the Installations table ordering for type and platform.
Things work by simply adding cluster, but perhaps we should now revisit this logic as it is counter-intuitive.

Also, we currently allow linking both devices and virtualmachines but the code always favours device if present.
I have added a constraint to the model that only one of the three (device, VM, or cluster) is allowed to be present.
Docs say: A cluster of VirtualMachines. Each Cluster may optionally be associated with one or more Devices.
This should therefore not be a problem, functionally speaking. But this might break if someone has incompatible data.

Should we support installations which are not linked to a platform? Does it make sense to have them?

@wkoot wkoot linked a pull request Sep 22, 2023 that will close this issue
wkoot added a commit that referenced this issue Oct 4, 2023
wkoot added a commit that referenced this issue Oct 4, 2023
wkoot added a commit that referenced this issue Oct 4, 2023
@wkoot wkoot closed this as completed in #29 Oct 4, 2023
wkoot added a commit that referenced this issue Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants