Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtsummary in this round of table updates #9287

Open
rdstern opened this issue Dec 1, 2024 · 5 comments
Open

Add gtsummary in this round of table updates #9287

rdstern opened this issue Dec 1, 2024 · 5 comments
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Dec 1, 2024

@Patowhiz I have realised your current impressive style button/sub-dialog, does not include the styles for numbers in the tables, etc.

I suggest adding gtsummary into the packages in R-Instat. Include a tab (maybe?) with style_number, etc. There are 5, and the style_number is probably by far the most important. Is there an equivalent in gt?

Then there is also style_percent, style_pvalue, style_ratio, style_signif. Maybe they are all provided?

@rdstern rdstern added this to the 0.8.1 milestone Dec 1, 2024
@Patowhiz
Copy link
Contributor

Patowhiz commented Dec 2, 2024

@rdstern I'm not sure if gtsummary can write to an existing gt object and whether it is conceptually correct to do it that way, but I'm aware that gt allows you to put in custom functions that will do formats that it doesn't cover. We could explore both options to cover what is not covered by gt by default.

Current Number Formatting Options
1

Input text box that allows you to enter an expression for custom formats.
2

@rdstern
Copy link
Collaborator Author

rdstern commented Dec 2, 2024

@Patowhiz thanks for that reply. Those you have already in place look impressive for now, so I retract the suggestion of the addition of the gtsummary functions for this round of updates. Let's practice on what you have already put in place first.

I still think gtsummary is so interesting, we will certainly be adding it soon - so why not now. Could you just add it into the implementation for the next version. Then we can always try using it via a script as we play later.

@Patowhiz
Copy link
Contributor

Patowhiz commented Dec 2, 2024

@rdstern for clarity, are you saying that we add the gtsummary package in R-Instat as part of it's installation or you want a tab on the sub-dialog that implements gtsummary functions in a similar way that we did for gt?

@rdstern
Copy link
Collaborator Author

rdstern commented Dec 2, 2024

@Patowhiz for now, just as part of the installation. You have enough already. The tab - if needed, can come next year.

@Patowhiz
Copy link
Contributor

Patowhiz commented Dec 3, 2024

@N-thony kindly add the R package as suggested by @rdstern.

@rdstern rdstern changed the title Add gtsummary in this round of table updates and include style_number and other features? Add gtsummary in this round of table updates Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants