Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: 1.2.21 #63

Closed
wants to merge 1 commit into from
Closed

content: 1.2.21 #63

wants to merge 1 commit into from

Conversation

jfmcquade
Copy link
Collaborator

Notably, this includes the changes made to the parsed sheets by the latest version of the template parser, updated in IDEMSInternational/open-app-builder#2211 to parse answer lists and to add auto-generated names to rows that do not specify their own.

Copy link

github-actions bot commented Apr 18, 2024

Visit the preview URL for this PR (updated for commit a87ee46):

https://idems-debug--pr63-content-1-2-21-cs84539r.web.app

(expires Fri, 03 May 2024 10:47:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2bfd21fc73bf25db0e74968614b72bee30e3476

@esmeetewinkel
Copy link
Collaborator

@jfmcquade My Chrome doesn't like this preview link at all! Do you get the same?
image

@jfmcquade
Copy link
Collaborator Author

@jfmcquade My Chrome doesn't like this preview link at all! Do you get the same?

Hmm yes I get the same warning in Chrome. Firefox and Safari don't complain.

This is what Google's "Safe Browsing" feature says:
Screenshot 2024-04-19 at 11 36 23

I would hope this is just an issue with the URL generated for this particular PR preview. I couldn't figure out a way to generate a new URL for a preview of this same PR, so I've made a duplicate PR here: #64. The preview link generated on that PR is working fine for me, with no warning from Chrome, so I don't think we should have any issues with merging – I'll close this PR in favour of that one.

@jfmcquade jfmcquade closed this Apr 19, 2024
@esmeetewinkel esmeetewinkel deleted the content/1.2.21 branch May 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants