Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test_1 - metadata does not come back in the right format. "definition from summary" is all that is returned. #95

Closed
Tracked by #94 ...
ChrisMarsh82 opened this issue Mar 27, 2024 · 3 comments
Assignees

Comments

@ChrisMarsh82
Copy link

ChrisMarsh82 commented Mar 27, 2024

This is the case for all functions

@lilyclements
Copy link
Collaborator

lilyclements commented Mar 27, 2024

This is currently intentional. We need to discuss here how we want to do this. The summary is one file and the definitions is another. What if the user updates the summary and not the definitions file?

My idea at the moment is that the time stamps will be useful to match the definitions with the appropriate summary.
Presumably we call the most recent summary, and the definitions that corresponds to that? (Rather than calling the most recent definitions).

What if there is no corresponding definition?

@lilyclements
Copy link
Collaborator

I have fixed for "annual_rainfall_summaries" in PR #103. I will fix in the others tomorrow

@lilyclements
Copy link
Collaborator

lilyclements commented Mar 28, 2024

This can now be closed after PR #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants