Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annual_temperature_summaries issues #96

Closed
3 tasks done
Tracked by #101
ChrisMarsh82 opened this issue Mar 27, 2024 · 2 comments
Closed
3 tasks done
Tracked by #101

annual_temperature_summaries issues #96

ChrisMarsh82 opened this issue Mar 27, 2024 · 2 comments

Comments

@ChrisMarsh82
Copy link

ChrisMarsh82 commented Mar 27, 2024

@ChrisMarsh82 ChrisMarsh82 mentioned this issue Mar 27, 2024
6 tasks
@lilyclements
Copy link
Collaborator

lilyclements commented Mar 27, 2024

@ChrisMarsh82 I've mentioned when making these changes that we now have an override = FALSE by default. I suspect a lot of issues you mention may be because of the override = FALSE by default, so it is calling the saved summaries by default. This means that the changes to the definitions file are not being read in.

  1. This is because by default override = FALSE, so it is calling the saved summary data. Try running with override = TRUE.
    E.g.
epicsawrap::annual_temperature_summaries("zm", "test_1", override = TRUE)
  1. See 1.
  2. Fixed by Fixing error in total_temperature_summaries function: is.logical to as.logical #102. Issue was that I was running is.logical, not as.logical. Thanks for the spot.

@lilyclements
Copy link
Collaborator

lilyclements commented Mar 28, 2024

This can now be closed after PR #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants