From 6d29c12f6830712ee678021da50cb1d107e1915e Mon Sep 17 00:00:00 2001
From: chrismclarke <chris.m.clarke@live.co.uk>
Date: Thu, 19 Dec 2024 17:47:35 -0800
Subject: [PATCH] feat: add support for combo_box child data_items

---
 .../combo-box-modal.component.html            |  2 +-
 .../combo-box-modal.component.ts              | 11 ++--
 .../combo-box/combo-box.component.ts          | 54 ++++++++++++-------
 .../data-items/data-items.service.ts          |  5 ++
 src/app/shared/utils/utils.ts                 |  1 -
 5 files changed, 48 insertions(+), 25 deletions(-)

diff --git a/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.html b/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.html
index 397245aca7..6c6084e384 100644
--- a/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.html
+++ b/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.html
@@ -8,7 +8,7 @@
         <div
           class="container-radio"
           [class.checked-radio]="form.get('answer').value === radio.name"
-          *ngFor="let radio of valuesFromListAnswers"
+          *ngFor="let radio of answerOptions()"
         >
           <label>
             <input
diff --git a/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.ts b/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.ts
index ba1158cb2f..16b68c1bf3 100644
--- a/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.ts
+++ b/src/app/shared/components/template/components/combo-box/combo-box-modal/combo-box-modal.component.ts
@@ -1,7 +1,6 @@
-import { Component, Input, OnInit } from "@angular/core";
+import { Component, input, Input, OnInit } from "@angular/core";
 import { FlowTypes } from "src/app/shared/model";
 import {
-  getAnswerListParamFromTemplateRow,
   getBooleanParamFromTemplateRow,
   getNumberParamFromTemplateRow,
   getStringParamFromTemplateRow,
@@ -16,8 +15,8 @@ import { ModalController } from "@ionic/angular";
   styleUrls: ["./combo-box-modal.component.scss"],
 })
 export class ComboBoxModalComponent implements OnInit {
+  public answerOptions = input.required<IAnswerListItem[]>();
   @Input() row: FlowTypes.TemplateRow;
-  @Input() template: FlowTypes.Template;
   @Input() selectedValue: string;
   @Input() customAnswerSelected: boolean;
   @Input() style: string;
@@ -29,7 +28,10 @@ export class ComboBoxModalComponent implements OnInit {
   inputPosition: boolean = false;
   maxLength: number = 30;
   placeholder: string = "";
-  constructor(private fb: FormBuilder, private modalController: ModalController) {}
+  constructor(
+    private fb: FormBuilder,
+    private modalController: ModalController
+  ) {}
 
   ngOnInit() {
     this.getParams();
@@ -37,7 +39,6 @@ export class ComboBoxModalComponent implements OnInit {
   }
 
   getParams() {
-    this.valuesFromListAnswers = getAnswerListParamFromTemplateRow(this.row, "answer_list", null);
     this.textTitle = getStringParamFromTemplateRow(this.row, "text", null);
     this.inputAllowed = getBooleanParamFromTemplateRow(this.row, "input_allowed", false);
     this.inputPosition =
diff --git a/src/app/shared/components/template/components/combo-box/combo-box.component.ts b/src/app/shared/components/template/components/combo-box/combo-box.component.ts
index 1054119771..48dbb5d97b 100644
--- a/src/app/shared/components/template/components/combo-box/combo-box.component.ts
+++ b/src/app/shared/components/template/components/combo-box/combo-box.component.ts
@@ -1,5 +1,4 @@
-import { Component, Input, OnDestroy, OnInit } from "@angular/core";
-import { FlowTypes } from "../../../../model";
+import { Component, computed, OnDestroy, OnInit } from "@angular/core";
 import { ModalController } from "@ionic/angular";
 import { ComboBoxModalComponent } from "./combo-box-modal/combo-box-modal.component";
 import {
@@ -10,8 +9,9 @@ import {
 } from "src/app/shared/utils";
 import { TemplateBaseComponent } from "../base";
 import { ITemplateRowProps } from "../../models";
-import { TemplateService } from "../../services/template.service";
-import { ReplaySubject } from "rxjs";
+import { ReplaySubject, map, filter, switchMap } from "rxjs";
+import { DataItemsService } from "../data-items/data-items.service";
+import { toObservable, toSignal } from "@angular/core/rxjs-interop";
 
 @Component({
   selector: "plh-combo-box",
@@ -22,17 +22,35 @@ export class TmplComboBoxComponent
   extends TemplateBaseComponent
   implements ITemplateRowProps, OnInit, OnDestroy
 {
-  @Input() template: FlowTypes.Template;
-  placeholder: string;
-  prioritisePlaceholder: boolean;
-  style: string;
-  text = "";
-  customAnswerSelected: boolean = false;
-  customAnswerText: string;
-  answerList: IAnswerListItem[];
+  public placeholder: string;
+  public prioritisePlaceholder: boolean;
+  private style: string;
+  public text = "";
+  private customAnswerSelected: boolean = false;
+  private customAnswerText: string;
   private componentDestroyed$ = new ReplaySubject(1);
 
-  constructor(private modalController: ModalController, private templateService: TemplateService) {
+  // HACK - allow combo_box to include data_items child row to define answer list
+  private dataItemRows = toSignal(
+    toObservable(this.rows).pipe(
+      map((rows) => rows.find((r) => r.type === "data_items")),
+      filter((row) => row !== undefined),
+      switchMap((row) => this.dataItemsService.getItemsObservable(row, this.parent.templateRowMap))
+    )
+  );
+
+  private answerOptions = computed(() => {
+    const dataItemRows = this.dataItemRows();
+    if (dataItemRows !== undefined) {
+      return (dataItemRows as IAnswerListItem[]) || [];
+    }
+    return getAnswerListParamFromTemplateRow(this.rowSignal(), "answer_list", []);
+  });
+
+  constructor(
+    private modalController: ModalController,
+    private dataItemsService: DataItemsService
+  ) {
     super();
   }
 
@@ -40,15 +58,16 @@ export class TmplComboBoxComponent
     this.getParams();
 
     this.customAnswerSelected =
-      this.answerList.length > 0 && this._row.value
-        ? !this.answerList.find((x) => x.name === this._row.value)
+      this.answerOptions().length > 0 && this._row.value
+        ? !this.answerOptions().find((x) => x.name === this._row.value)
         : false;
 
     this.text = "";
     if (this._row.value) {
       this.text = this.customAnswerSelected
         ? this.customAnswerText
-        : this.answerList.find((answerListItem) => answerListItem.name === this._row.value)?.text;
+        : this.answerOptions().find((answerListItem) => answerListItem.name === this._row.value)
+            ?.text;
     }
   }
 
@@ -60,7 +79,6 @@ export class TmplComboBoxComponent
       false
     );
     this.style = getStringParamFromTemplateRow(this._row, "style", "");
-    this.answerList = getAnswerListParamFromTemplateRow(this._row, "answer_list", []);
   }
 
   async openModal() {
@@ -68,8 +86,8 @@ export class TmplComboBoxComponent
       component: ComboBoxModalComponent,
       cssClass: "combo-box-modal",
       componentProps: {
+        answerOptions: this.answerOptions,
         row: this._row,
-        template: this.template,
         selectedValue: this.customAnswerSelected ? this.text : this._row.value,
         customAnswerSelected: this.customAnswerSelected,
         style: this.style,
diff --git a/src/app/shared/components/template/components/data-items/data-items.service.ts b/src/app/shared/components/template/components/data-items/data-items.service.ts
index ffa7138976..50b57b7e7e 100644
--- a/src/app/shared/components/template/components/data-items/data-items.service.ts
+++ b/src/app/shared/components/template/components/data-items/data-items.service.ts
@@ -45,6 +45,11 @@ export class DataItemsService {
                   const parsedItemList = await this.hackParseDataList(data);
                   const itemProcessor = new ItemProcessor(parsedItemList, parameter_list);
                   const { itemTemplateRows, itemData } = itemProcessor.process(rows);
+                  // if no child rows for data_items loop assume want back raw items
+                  if (rows.length === 0) {
+                    return itemData;
+                  }
+                  // otherwise process generated template rows
                   const itemRowsWithMeta = updateItemMeta(itemTemplateRows, itemData, dataListName);
                   const parsedItemRows = await this.hackProcessRows(
                     itemRowsWithMeta,
diff --git a/src/app/shared/utils/utils.ts b/src/app/shared/utils/utils.ts
index 2b2c9daf1c..cf854f96c0 100644
--- a/src/app/shared/utils/utils.ts
+++ b/src/app/shared/utils/utils.ts
@@ -223,7 +223,6 @@ export function getAnswerListParamFromTemplateRow(
   _default: IAnswerListItem[]
 ): IAnswerListItem[] {
   const params = row.parameter_list || {};
-  console.log(params[name]);
   return params.hasOwnProperty(name) ? parseAnswerList(params[name]) : _default;
 }