Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Data items: error trying to modify final fields #2327

Closed
jfmcquade opened this issue May 28, 2024 · 1 comment
Closed

[BUG] Data items: error trying to modify final fields #2327

jfmcquade opened this issue May 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jfmcquade
Copy link
Collaborator

jfmcquade commented May 28, 2024

Extracted from the PR description of #2325:

I'm not sure if related to this PR or not but starting to see issue with modifying final fields
image

(update - seeing on main - possibly may want to address after merge #2323)

I'm unable to replicate this (using comp_data_items) on master or the feature branch for #2325, @chrismclarke could you provide some more details?

This is very likely to be an issue introduced by #2312, and looking at the error in your screenshot I think the problem is to do with the row_index property (the only final property in the schemas for the persistedMemory and reactiveMemory adapters) and where that property is being saved: either at the top level of the doc or inside the data property. Potentially this is a new issue introduced by #2325 (which persists on master when data overwrites have been made on that feature branch), but probably unlikely.

@jfmcquade jfmcquade added the bug Something isn't working label May 28, 2024
@jfmcquade jfmcquade changed the title [BUG] [BUG] Data items: error trying to modify final fields May 31, 2024
@chrismclarke
Copy link
Member

OK, if not replicated when working locally I'd say probably safe to close for now - could be linked to a previous local dev state. Also as these issues are not tracked in production can just reopen if replicated in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants