Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Fix automatic adding of magic images #163

Open
Idrinth opened this issue Sep 30, 2016 · 9 comments
Open

Fix automatic adding of magic images #163

Idrinth opened this issue Sep 30, 2016 · 9 comments

Comments

@Idrinth
Copy link
Member

Idrinth commented Sep 30, 2016

5PG seems to use even more broken image naming now - more images slip through.

@Idrinth Idrinth self-assigned this Sep 30, 2016
@Idrinth Idrinth changed the title Fix automatic adding of magic imaged Fix automatic adding of magic imageds Sep 30, 2016
@Idrinth Idrinth changed the title Fix automatic adding of magic imageds Fix automatic adding of magic images Sep 30, 2016
@Idrinth Idrinth added this to the High effort expected milestone Oct 3, 2016
@Ardenian
Copy link
Contributor

Ardenian commented Oct 3, 2016

One could, if the 5PG images cannot be loaded, externally load them from the dotd wikia, as second option.
Alternatively, one could also think about storing them manually externally in some kind of data storage, since they are less likely to change whereas there might come new issues from 5PG in the future.

@Idrinth
Copy link
Member Author

Idrinth commented Oct 3, 2016

It's more of a naming issue, the api doesn't provide the correct names for the images :(

@Ardenian
Copy link
Contributor

Something that will hapen with everything they change. They change something and over here something gets broken. Might be ways to prevent that, though externalizing the magic images might be one easy way, considerng they aren't file-size heavy either.

@Idrinth
Copy link
Member Author

Idrinth commented Oct 12, 2016

would need the correct name for those as well then - if I don't find them where I expected them...

@Ardenian
Copy link
Contributor

Well, since you could name the images the way you want it would offer the advantage to be independent form their naming, though having to organize everything yourself.

@Idrinth
Copy link
Member Author

Idrinth commented Oct 12, 2016

I still need the source image to be found, ardenian, we are storing them locally once we found them, so they won't be requested from 5pg in any case.

@Theodotosp
Copy link
Collaborator

Do you need help on finding with this issue?

@Idrinth
Copy link
Member Author

Idrinth commented Oct 12, 2016

No, but thanks @Theodotosp , I just need to find the time to write the code to read the game's xml

@Ardenian
Copy link
Contributor

Ahh, I see. Well, dotd wikia might be an addition to get the images.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants