Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Change communication format from json to X #227

Open
Idrinth opened this issue Nov 4, 2016 · 4 comments
Open

Change communication format from json to X #227

Idrinth opened this issue Nov 4, 2016 · 4 comments

Comments

@Idrinth
Copy link
Member

Idrinth commented Nov 4, 2016

I'm wondering if changing the comunication format should be changed from json to something else to make the transfer quicker.
I thought about (binary) Thrift since it does technically support both php and javascript even if the javascript implementation is not currently in the apache repository.

Any other ideas?

@w20k
Copy link
Collaborator

w20k commented Nov 22, 2016

What's the main reason would be in chaning format?

@Idrinth
Copy link
Member Author

Idrinth commented Nov 22, 2016

size of the data and the result of unserializing the data.
If you have a look at a few of our jsons they are huge, so this could help reduce size a lot.

This is mostly meant to prepare for the next war, we got around 6KB for the raid search requests at the moment, I'd expect around 20KB during wars and not just once like it's now but every couple seconds.

@w20k
Copy link
Collaborator

w20k commented Nov 26, 2016

Got your point :)

Binary would be good, but I'm not sure how easy it's parsed from JS side.
Message Pack could be an option:
http://msgpack.org/index.html

@Idrinth
Copy link
Member Author

Idrinth commented Nov 26, 2016

There is an existing and supported library for javascript https://github.com/gossiperl/thrift-js-binary-protocol, it was just incompatible with the tests run, so...
msgpack also looks like something we could test

@Idrinth Idrinth added this to the No effort expected milestone Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants