WIP: Updated installation instructions,add to Google Calendar Feature,share on Facebook #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitvarkey
reviewed
Feb 21, 2018
| @@ -19,9 +19,19 @@ comes with virtualenv built-in. So create a virtual env by: | |||
| 1. `$ python3 -m venv Student_Council_Website` | |||
| 2. `$ . Student_Council_Website/bin/activate` | |||
|
|
|||
| virtual SCWebsite | |||
There was a problem hiding this comment.
It's a nice idea to quote these commands. Adding ``` and mentioning the language around the code will do that for you.
For example by adding ```bash around the stuff you added allows you to get the following.
virtual SCWebsite
source SCWebsite/bin/activate
cd SCWebsitewill even pull up some nice syntax highlighting!
There was a problem hiding this comment.
Okay. Will change that!
Thank you for suggesting!
| Install all dependencies: | ||
|
|
||
| pip install -r requirements.txt | ||
| pip install easy-thumbnails |
There was a problem hiding this comment.
Why don't you add these to the requirements.txt file so that we can avoid manual pip installations? You can do pip freeze > requirements.txt to get the updated package list from your virtualenv.
There was a problem hiding this comment.
Thanks for suggesting @abhijithanilkumar !
Will do that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #64
Add event to Google Calendar, and share on Facebook feature has been tested on dummy data.
Do not merge. After data is available, it will be updated and then it will be good to be reviewed for merging