From 0ddef449a00a07b742605ecc3c7efcd1581ba6c9 Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 5 Jan 2023 17:20:53 +0000 Subject: [PATCH 1/3] iss #202 add type to height_reference --- schema/iea43_wra_data_model.schema.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/schema/iea43_wra_data_model.schema.json b/schema/iea43_wra_data_model.schema.json index 8b0ce99..4a44a98 100644 --- a/schema/iea43_wra_data_model.schema.json +++ b/schema/iea43_wra_data_model.schema.json @@ -209,6 +209,10 @@ ] }, "height_reference": { + "type": [ + "string", + "null" + ], "title": "Height Reference", "description": "The height reference frame that is used to measure the item height. E.g. onshore this is ground level i.e. the item is 0.5 m above ground level. Offshore is a bit different as it can be 20 m above mean sea level or 20 m above lowest astronomical tide.", "enum": [ From e03055d4ec7220980382c70e7dbdb1ff7e5b3a8e Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 5 Jan 2023 17:23:21 +0000 Subject: [PATCH 2/3] iss #202 update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81ac014..9da60bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ types and units. 1. `sensor_body_size_mm` (Issue [#155](https://github.com/IEA-Task-43/digital_wra_data_standard/issues/155)) 1. To `logger_main_config`: 1. fix inconsistency with data types for `logger_firmware_version`. (Issue [#87](https://github.com/IEA-Task-43/digital_wra_data_standard/issues/87)) + 1. `height_reference` (Issue [#202](https://github.com/IEA-Task-43/digital_wra_data_standard/issues/202)) 1. To `logger_measurement_config` object: 1. added `logger_stated_boom_orientation_deg` (Issue [#190](https://github.com/IEA-Task-43/digital_wra_data_standard/issues/190)) 1. To `sensor_type` enum add: From 5c4f87dbb0bfc9305610bb411a227b5c02209d6e Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 6 Jan 2023 12:38:30 +0000 Subject: [PATCH 3/3] iss #202 update description --- schema/iea43_wra_data_model.schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/schema/iea43_wra_data_model.schema.json b/schema/iea43_wra_data_model.schema.json index 4a44a98..dd85a28 100644 --- a/schema/iea43_wra_data_model.schema.json +++ b/schema/iea43_wra_data_model.schema.json @@ -214,7 +214,7 @@ "null" ], "title": "Height Reference", - "description": "The height reference frame that is used to measure the item height. E.g. onshore this is ground level i.e. the item is 0.5 m above ground level. Offshore is a bit different as it can be 20 m above mean sea level or 20 m above lowest astronomical tide.", + "description": "The height reference frame that is used to measure the item height. E.g. onshore this is 'ground level' i.e. the item is 0.5 m above ground level. Offshore is a bit different as it can be 20 m above 'mean sea level' or 20 m above 'lowest astronomical tide' for a fixed structure or 20 m above 'sea level' for a floating lidar.", "enum": [ "ground_level", "mean_sea_level", @@ -228,7 +228,7 @@ }, "type": "object", "title": "IEA Wind Resource Assessment - Data Model", - "description": "This Data Model schema is a digital representation of a meteorological mast used for measureing the wind resource of a potential wind farm.", + "description": "This Data Model schema is a digital representation of a meteorological mast used for measuring the wind resource of a potential wind farm.", "properties": { "author": { "type": "string",