Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] (for v2.0) Should the lidar_config.date_from be required? #208

Open
stephenholleran opened this issue Jan 26, 2023 · 5 comments
Open
Assignees
Labels
breaking change Highlights that this issue will be a breaking change enhancement New feature or request

Comments

@stephenholleran
Copy link
Collaborator

From a pull request comment has sparked a review of this.
#201 (comment)

Should the lidar_config.date_from property by required? It is currently optional.

@abohara
Copy link
Collaborator

abohara commented Feb 16, 2023

@stephenholleran I don't see why lidar_config.date_from and by extension the date_from in other tables should be optional. Plus +1 from me to make it required.

@kersting
Copy link
Collaborator

@stephenholleran and @abohara I think that if you don't make it required, then there is no way to track to what period that configuration is associated to.

@abohara
Copy link
Collaborator

abohara commented Mar 1, 2023

@kersting Agreed

@stephenholleran Can we close ?

@stephenholleran
Copy link
Collaborator Author

Hi @abohara, @kersting,

I think we are all agreed to make it required.

@stephenholleran Can we close ?

We won't close this issue as we now have to implement it. We will use this issue to track it in the kanban board.

This will be a breaking change so I'll mark this as a version 2.0 release.

@stephenholleran stephenholleran changed the title [SCHEMA] Should the lidar_config.date_from be required? [SCHEMA] (for v2.0) Should the lidar_config.date_from be required? Mar 2, 2023
@stephenholleran stephenholleran self-assigned this Mar 2, 2023
@stephenholleran stephenholleran added the enhancement New feature or request label Mar 2, 2023
@kersting
Copy link
Collaborator

kersting commented Mar 2, 2023

@stephenholleran let me know if I can help either with the implementation or with the review (knowing that I need to do some implementation in other parts of the code).

@stephenholleran stephenholleran added breaking change Highlights that this issue will be a breaking change enhancement New feature or request and removed enhancement New feature or request question Further information is requested labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Highlights that this issue will be a breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants