-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] (for v2.0) Should the lidar_config.date_from be required? #208
Comments
@stephenholleran I don't see why |
@stephenholleran and @abohara I think that if you don't make it required, then there is no way to track to what period that configuration is associated to. |
@kersting Agreed @stephenholleran Can we close ? |
I think we are all agreed to make it required.
We won't close this issue as we now have to implement it. We will use this issue to track it in the kanban board. This will be a breaking change so I'll mark this as a version 2.0 release. |
@stephenholleran let me know if I can help either with the implementation or with the review (knowing that I need to do some implementation in other parts of the code). |
From a pull request comment has sparked a review of this.
#201 (comment)
Should the lidar_config.date_from property by required? It is currently optional.
The text was updated successfully, but these errors were encountered: