Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] device_vertical_orientation inconsistent naming, missing the '_id' on the end for an enum #234

Open
stephenholleran opened this issue Oct 12, 2023 · 1 comment
Labels
breaking change Highlights that this issue will be a breaking change bug Something isn't working

Comments

@stephenholleran
Copy link
Collaborator

Describe the bug
The device_vertical_orientation name is inconsistent with other emuns such as measurement_station_type_id, logger_oem_id, mast_geometry_id, measurement_units_id, statistic_type_id, sensor_type_id, mounting_type_id and structure_type_id as it is missing the "_id" on the end.

Expected behavior
As this is an enum, it is expected to have an "_id" on the end of it's name.

Screenshots
image

Additional context
This will be a breaking change as it is renaming a property.

Similar issue for plant_type.

@stephenholleran stephenholleran added bug Something isn't working breaking change Highlights that this issue will be a breaking change labels Oct 12, 2023
@stephenholleran stephenholleran changed the title [device_vertical_orientation] inconsistent naming, missing the '_id' on the end for an enum [SCHEMA] device_vertical_orientation inconsistent naming, missing the '_id' on the end for an enum Oct 12, 2023
@kersting
Copy link
Collaborator

@stephenholleran thanks for pointing this. We have also another open issue that will likely result in a break change. I suggest we tackled them together. #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Highlights that this issue will be a breaking change bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants