-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated rotor definition with various minor fixes #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as well as updated airfoil data that fixes wrong FFA-W3 shapes, closes #32
ptrbortolotti
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good to merge whenever you are!
Shouldn’t we get the updated OpenFAST model done before we merge? |
updated output channels, nr aero sections and minor comments
updated output channels, nr aero sections and minor formating
updated output channels, nr aero sections and minor formating
updated output channels, nr aero sections and minor formating
rounded up thickness numbers for cinsistenvy with pc file
rounded up +/-180deg and thickness numbers
rounded up +/-180deg and thickness numbers
rounded up thicknesses for consistency with pc file
removed monopile output channels
removed monopile output channels
…-RWT into rotor_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following in the WindIO definition of the rotor:
HAWC2:
OpenFAST: