Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data for end to end test of pivot base creation #31

Closed
jmkerloch opened this issue Feb 7, 2023 · 11 comments · Fixed by #38
Closed

add data for end to end test of pivot base creation #31

jmkerloch opened this issue Feb 7, 2023 · 11 comments · Fixed by #38
Assignees
Labels
test Related to test
Milestone

Comments

@jmkerloch
Copy link
Contributor

We need to have some data available to test end to end pivot base creation :

For this we could use bdtopo from IGN : https://geoservices.ign.fr/bdtopo with table:
- troncon_de_route
- non_communication

This should be stored as a .sql dump.

This dump could then be used in a docker-compose so the input database can be available in test.

@jmkerloch jmkerloch added the test Related to test label Feb 7, 2023
@jmkerloch jmkerloch added this to the sprint2 milestone Feb 7, 2023
@jmkerloch
Copy link
Contributor Author

jmkerloch commented Feb 7, 2023

@lgrd @azarz can you confirm that these are the only needed tables ?

@lgrd
Copy link
Collaborator

lgrd commented Feb 7, 2023

Where do you want to store this dump @jmkerloch ?

@azarz
Copy link
Member

azarz commented Feb 7, 2023

@lgrd @azarz can you confirm that these are the only needed tables ?

These are the only needed tables

@jmkerloch
Copy link
Contributor Author

@lgrd this dump will be stored in this repository

@lgrd
Copy link
Collaborator

lgrd commented Feb 7, 2023

we can't do that... if you have multiple bdtopo version, or data (like osm), we will not store a dump for each one.
@azarz told me that we could use an URL in the CI. This way could be an option.

@Guts
Copy link
Collaborator

Guts commented Feb 7, 2023

Sure, but what URL should we use? We can't seriously rely on the actual delivery service of BDTopo...

@gwenandres
Copy link
Contributor

Here is an example of what could be dumps needed to automate tests.

I produce these dump doing these steps :

  • Dowloading BDTOPO GPKG (department 13)
  • Loading tables (troncon_de_route, non_communication, arrondissement_municipal)
  • Create two tables extracting troncon_de_route and non_communication on Marseille 10ème
  • Dump this 2 tables (in dump format, lighter than sql format)

dumps.zip

@lgrd
Copy link
Collaborator

lgrd commented Feb 9, 2023

Thanks for the dump ! Have you already used it for a generation ?

@gwenandres
Copy link
Contributor

I use the entire PACA data for my first test. Then I make this subset and @jmkerloch use it for generation.

@jmkerloch here are dumps in sql format

dumps_sql.zip

@azarz
Copy link
Member

azarz commented Feb 16, 2023

Sure, but what URL should we use? We can't seriously rely on the actual delivery service of BDTopo...

Is the link to the dump uploaded here by @gwenandres permanent? If so, we could maybe use that in the CI 🤷
https://github.com/IGNF/route-graph-generator/files/10744559/dumps_sql.zip

@lgrd
Copy link
Collaborator

lgrd commented Feb 27, 2023

You can also use https://storage.gra.cloud.ovh.net/v1/AUTH_366279ce616242ebb14161b7991a8461/road2/dumps.zip which is an object storage of IGN. It is a temporary solution until we have a the "entrepot" and all its services.

@jmkerloch jmkerloch linked a pull request Mar 1, 2023 that will close this issue
@jmkerloch jmkerloch moved this to 👀 In review in Road2 backlog Mar 1, 2023
@jmkerloch jmkerloch modified the milestones: sprint2, sprint3 Mar 1, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Road2 backlog Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants