Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #261: Annotation with a Non-Rectangular Polygon #80

Open
glenrobson opened this issue Oct 7, 2021 · 17 comments
Open

Recipe #261: Annotation with a Non-Rectangular Polygon #80

glenrobson opened this issue Oct 7, 2021 · 17 comments
Assignees
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

Building on the successful approval of #78 and #77 this recipe demonstrates how to make an annotation that targets a non rectangular area using a SVG shape as the target. This recipe is supported in Mirador 3.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the October 2021 milestone Oct 7, 2021
@julsraemy
Copy link

Just a small remark: in the first paragraph of the Implementation Notes, the hyperlink to the Presentation API 3.0 is missing (I guess it's just an omission in Markdown).

@kirschbombe
Copy link

Should 'manifest' in the final paragraph of the Implementation Notes be capitalized?

@triplingual
Copy link

Entering my routine note that I voted 👍🏻 for my recipe

@azaroth42
Copy link
Member

👎 Strongly feel that recipes for 3.0 should not refer to 2.1 but instead either describe what is needed, or point to the relevant specification. (Also various editorial issues as others have commented)

@glenrobson
Copy link
Member Author

@azaroth42 would changing the link from 2.1 to https://www.w3.org/TR/annotation-model/#svg-selector change your vote? It talks briefly about the scale of the SVG being relative to the image so we might also need to take some of the canvas language from 2.1 into the recipe.

@zimeon
Copy link
Member

zimeon commented Oct 14, 2021

Like @azaroth42, I feel strongly that we should not link into the 2.1 spec. I would be OK copy or paraphrase content from 2.1, but link only to 3! Hence 👎 vote

@azaroth42
Copy link
Member

azaroth42 commented Oct 14, 2021

Yes, either referring to another current spec (and svg-selector is the obvious candidate) or just importing the content from 2.1 into the recipe, which is probably better as it's more specific guidance for this particular scenario. Indeed, the notion of the cookbook came from discussions about how to avoid the content in the 2.1 spec about uses of annotations at the beginning of the work on 3.0 -- that instead we should refer to other specs for definitions, and have recipes / implementation notes to describe how to implement particular use cases. So it's great that the recipe is bringing that to fruition ... it should just not do it by pointing to the 2.x spec as if 3.x was mistakenly missing something.

@triplingual
Copy link

Noting with bemusement that an earlier version of this recipe quoted the relevant part of 2.1 inline. 😇

@azaroth42
Copy link
Member

👍 to the earlier version :)

@mixterj
Copy link

mixterj commented Oct 14, 2021

Along with @zimeon and @azaroth42 I think we should not link to 2.1 spec. I also think that in-line text is the best option.

@glenrobson
Copy link
Member Author

Issue 80 (Recipe #261: Annotation with a Non-Rectangular Polygon )

+1: 13 [awead cubap glenrobson irv jcreel kirschbombe markpatton markpbaggett mbennett-uoe nfreire shuddles thehabes triplingual]
0: 0 []
-1: 11 [azaroth42 dlpierce jonhartzler jtweed julsraemy ksclarke mcwhitaker mixterj rsinghal tpendragon zimeon]
Not TRC: 0 []
Ineligible: 1 [scossu]

Result: 13 / 24 = 0.54

No super majority, issue is referred to ex officio for decision

@regisrob
Copy link
Member

While reading this recipe I wonder if it would make sense to add a note on the fact that when using non-rectangular annotations it is sometimes useful to also capture the rectangular region that comprises the polygon, so that it can be easily extracted and displayed using the Image API.
But it should rather be a separate recipe explaining this specific use case, i.e. when you want to use non-rectangular shapes to annotate an image and be able to display the annotated image regions in a web page (which would imply to use a Choice of selectors if I recall correctly...). Is there already a candidate recipe for that? If not, does it make sense to have one?

@triplingual
Copy link

@regisrob That sounds like a good candidate for a recipe, taking this recipe (how to include a non-rectangular annotation) to an additional level of utility and explanation (one part of consequences for using a non-rectangular polygon annotation). We thought among the cookbook authors that this imagined recipe can be mentioned and speculatively linked to in this one.

@regisrob
Copy link
Member

regisrob commented Nov 3, 2021

@triplingual I agree, and I'd be interested in writing this potential candidate recipe, but the main problem is the time available (at least until mid-December...)

@glenrobson
Copy link
Member Author

The requested changes have been made here:

IIIF/cookbook-recipes@89d6146

Please could the TRC ex-officio members vote on this comment either thumbs up/down or confused face to indicate your acceptance now the changes have been made?

@glenrobson
Copy link
Member Author

Comment from the ex-offico's:

"I think the “(noticable if the 0,0 point is different than the Canvas’s)” addition should be deleted because it isn’t always correct — think of two rectangles both anchored at 0,0 but different"

triplingual added a commit to IIIF/cookbook-recipes that referenced this issue Mar 4, 2022
@glenrobson
Copy link
Member Author

Ex-officos have approved the changes Trip has made so I will merge the recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants