Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #258: Tagging with an External Resource #85

Open
glenrobson opened this issue Dec 2, 2021 · 10 comments
Open

Recipe #258: Tagging with an External Resource #85

glenrobson opened this issue Dec 2, 2021 · 10 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

Building on the previous annotation recipes and in particular the basic tagging recipe approved in #77. Recipe 258 extends the simple tagging recipe by linking an annotation to an external URI rather than just a simple text string. This can be useful in tagging entities contained in textual content, places on a map to a Gazetteer or as in the example given linking a photograph of a fountain to the Wikidata entry.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@kirschbombe
Copy link

  • Typo at the end of the second paragraph in the Implementation notes section: "it must be a real URI at the time of the creation of the Annoation"
  • Third paragraph of Implementation notes section, the penultimate sentence needs subject/verb agreement
  • In the example manifest, do we need to include the human readable tag since recipes are supposed show the simplest implementation of a property or use case?

@thehabes
Copy link

thehabes commented Dec 8, 2021

Include manifest.json lines 49 and 66 in the highlighting (the open and closing brackets for the Annotation)

@markpbaggett
Copy link

In the example section, annotation is misspelled: "While the Annodation body that points to the Wikidata entry for the fountain is valid all alone"...

@triplingual
Copy link

I promise I know how to spell Annnnotation.

@julsraemy
Copy link

julsraemy commented Dec 8, 2021

It would be better to use the concept URI of Wikidata: http://www.wikidata.org/entity/Q18624915 instead of https://www.wikidata.org/wiki/Q18624915:

              "body": [
                {
                  "type": "SpecificResource",
                  "source": "http://www.wikidata.org/entity/Q18624915"
                },

@zimeon
Copy link
Member

zimeon commented Dec 8, 2021

My 👍 is with wikidata URI (and spelling) fix

@markpbaggett
Copy link

Great point @julsraemy . I think making sure that URI is content negotiable for RDF is important.

@triplingual
Copy link

Habitual notice that I voted 👍🏻 for my own recipe.

@glenrobson
Copy link
Member Author

Issue 85 (Recipe #258: Tagging with an External Resource)

+1: 22 [azaroth42 cubap dlpierce emulatingkat glenrobson hadro irv jtweed julsraemy kirschbombe ksclarke markpbaggett mikeapp mixterj mposton-folger nfreire regisrob rentonsa thehabes tpendragon triplingual zimeon]
0: 0 []
-1: 0 []
Not TRC: 1 [digitaldogsbody]
Ineligible: 2 [cjnishioka gigamorph]

Result: 22 / 22 = 1.00

Super majority is in favor, issue is approved

triplingual added a commit to IIIF/cookbook-recipes that referenced this issue Feb 4, 2022
triplingual added a commit to IIIF/cookbook-recipes that referenced this issue Feb 4, 2022
@triplingual
Copy link

@kirschbombe

* In the example manifest, do we need to include the human readable tag since recipes are supposed show the simplest implementation of a property or use case?

It's been a minute, but if I recall correctly, we discussed this and decided to include it so a viewer would have something to show the visitor even if or especially if the Wikidata URI wasn't linked or displayed, and to show a good practice in that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants