Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-rid-of-github-path-in-dependencies #33

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

aalbino2
Copy link
Collaborator

@aalbino2 aalbino2 commented Jan 8, 2025

No description provided.

@aalbino2 aalbino2 requested a review from ka-sarthak January 8, 2025 12:34
@aalbino2 aalbino2 linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link
Collaborator

@ka-sarthak ka-sarthak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml changes look good. Added some comments for the documentation

README.md Outdated Show resolved Hide resolved
"lakeshore-nomad-plugin @ git+https://github.com/IKZ-Berlin/lakeshore-nomad-plugin.git@69a6deb3f0e99d7b0dc66714105dd62a56f157e9",
"laytec_epitt_plugin @ git+https://github.com/IKZ-Berlin/laytec_epitt_nomad_plugin.git@f4953ac4ecb55b7003dee323d7d7f473e49ab4e3",
"statsmodels"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These git paths will change in the near future, as we update the plugins. Making this a part of the docu will require us to update it every time.

"lakeshore-nomad-plugin @ git+https://github.com/IKZ-Berlin/lakeshore-nomad-plugin.git@69a6deb3f0e99d7b0dc66714105dd62a56f157e9",
"laytec_epitt_plugin @ git+https://github.com/IKZ-Berlin/laytec_epitt_nomad_plugin.git@f4953ac4ecb55b7003dee323d7d7f473e49ab4e3",
"statsmodels"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These git paths will change in the near future, as we update the plugins. Making this a part of the docu will require us to update it every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of github path in dependencies
2 participants