Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of " vs ' #34

Open
ErwinJunge opened this issue Oct 22, 2017 · 5 comments
Open

Inconsistent use of " vs ' #34

ErwinJunge opened this issue Oct 22, 2017 · 5 comments
Labels
easy help-wanted up-for-grabs

Comments

@ErwinJunge
Copy link
Contributor

The code uses " for some strings and ' for others. This is poor style, we should pick one. There is no preference for either one, so whoever fixes this issue gets the freedom to choose.

https://www.python.org/dev/peps/pep-0008/#id25
@aman-roy
Copy link

Can I Work on this?

@aman-roy aman-roy mentioned this issue Oct 23, 2017
Open
@aman-roy
Copy link

Check PR.

@ErwinJunge
Copy link
Contributor Author

@rohithasrk lgtm

@aman-roy
Copy link

Please merge @rohithasrk

@rohithasrk
Copy link
Contributor

Hi @aman-roy. Will test it on the working instance in some time and merge it if it's working. Give me a little time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help-wanted up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErwinJunge @aman-roy @rohithasrk