Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder not working from Harvard Dataverse #328

Open
pdurbin opened this issue Dec 12, 2024 · 3 comments
Open

Binder not working from Harvard Dataverse #328

pdurbin opened this issue Dec 12, 2024 · 3 comments
Assignees
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) Size: 10 A percentage of a sprint. Waiting

Comments

@pdurbin
Copy link
Member

pdurbin commented Dec 12, 2024

For now, a couple links:

@pdurbin pdurbin added the Size: 10 A percentage of a sprint. label Dec 12, 2024
@pdurbin pdurbin self-assigned this Dec 12, 2024
@pdurbin pdurbin moved this to In Progress 💻 in IQSS Dataverse Project Dec 12, 2024
pdurbin added a commit to IQSS/repo2docker that referenced this issue Dec 16, 2024
…1388

When the Dataverse content provider was added in jupyterhub#739 it had the
flexibility to operate directly on Dataverse files like this:

repo2docker https://dataverse.harvard.edu/file.xhtml?persistentId=doi:10.7910/DVN/6ZXAGT/3YRRYJ

However, being able to operate only on datasets (files are stored
in datasets in Dataverse) is enough. That is, this will still work:

repo2docker doi:10.7910/DVN/TJCLKP

And that's all we need.

This simplification builds upon the work in jupyterhub#1388 where the content
of the dataset landing page is not retrieved from the DOI of the
dataset. Instead, the redirect location is fetched, which is all
the Dataverse content provider needs to determine which of the
100+ installations of Dataverse hosts the DOI.

This change should be a no-op for any installation of Datavese with
Binder integration enabled.

Harvard Dataverse (one of the 100+ installations) specifically is
not working with Binder due to a firewall that is blocking
https://dataverse.harvard.edu/citation
The simplification in this commit means that the Dataverse
content provider no longer needs to follow `/citation` to determine
what is on the other side (dataset.xhtml, file.xhtml, etc.). It
assumes that the DOI is always for a dataset (not a file), which
is the expectation we have always set for the Binder tool.

We are tracking Binder not working with Harvard Dataverse here:
IQSS/dataverse.harvard.edu#328
@pdurbin
Copy link
Member Author

pdurbin commented Dec 16, 2024

Two updates:

@pdurbin
Copy link
Member Author

pdurbin commented Dec 16, 2024

Unblocking /citation seemed to work. 🎉 https://mybinder.org/v2/dataverse/10.7910/DVN/TJCLKP/ (which is where the Binder button sends you, for example, from https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/TJCLKP ) opens up my dataset:

Screenshot 2024-12-16 at 11 29 35 AM

For a longer term fix I'll keep monitoring my PR at yuvipanda/repo2docker#7 which I announced at https://jupyter.zulipchat.com/#narrow/channel/103349-ask-anything/topic/Binder.20Dataverse.20error/near/489270587

@pdurbin
Copy link
Member Author

pdurbin commented Dec 19, 2024

This is the new PR to track:

Once it's merged and deployed, we can try pulling the block back in place for /citation.

While we're bothering those folks, we'll unblock /openapi, which was asked about at https://jupyter.zulipchat.com/#narrow/channel/103349-ask-anything/topic/Binder.20Dataverse.20error/near/489373873

@cmbz cmbz added the FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) label Jan 2, 2025
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) Size: 10 A percentage of a sprint. Waiting
Projects
Status: In Progress 💻
Development

No branches or pull requests

2 participants