removed an unnecessary @todo (#10623)

IQSS · Aug 21, 2024 · 2512eab · 2512eab
1 parent 5ba2888
commit 2512eab
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/globus/GlobusServiceBean.java b/src/main/java/edu/harvard/iq/dataverse/globus/GlobusServiceBean.java
@@ -687,19 +687,16 @@ public void globusUpload(JsonObject jsonData, ApiToken token, Dataset dataset, S
         String logFileName = System.getProperty("com.sun.aas.instanceRoot") + File.separator + "logs" + File.separator + "globusUpload_" + dataset.getId() + "_" + logTimestamp
                 + ".log";
         FileHandler fileHandler;
-        boolean fileHandlerSuceeded = false;
+
         try {
             fileHandler = new FileHandler(logFileName);
             globusLogger.setUseParentHandlers(false);
-            fileHandlerSuceeded = true;
         } catch (IOException | SecurityException ex) {
             Logger.getLogger(DatasetServiceBean.class.getName()).log(Level.SEVERE, null, ex);
-            //return; // @todo I don't think we need to return here? 
             fileHandler = null;
-
         }
 
-        if (fileHandlerSuceeded) {
+        if (fileHandler != null) {
             globusLogger.addHandler(fileHandler);
         } else {
             globusLogger = logger;