Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resources to close JsonReader "report = Json.createReader(reader).readObject();" in method addUsageMetricsFromSushiReport(...) and to close JsonReader "report = Json.createReader(reader).readObject();" in method ddUsageMetricsFromSushiReportAll(...) and to close JsonReader "JsonObject report = Json.createReader(connection.getInputStream()).readObject();" in method updateCitationsForDataset(...) in MakeDataCountApi.java #10056

Closed
rtreacy opened this issue Oct 26, 2023 · 5 comments · Fixed by #10062
Closed

Use try-with-resources to close JsonReader "report = Json.createReader(reader).readObject();" in method addUsageMetricsFromSushiReport(...) and to close JsonReader "report = Json.createReader(reader).readObject();" in method ddUsageMetricsFromSushiReportAll(...) and to close JsonReader "JsonObject report = Json.createReader(connection.getInputStream()).readObject();" in method updateCitationsForDataset(...) in MakeDataCountApi.java #10056

rtreacy opened this issue Oct 26, 2023 · 5 comments · Fixed by #10062
Milestone
6.1

Comments

@rtreacy
Copy link
Contributor

rtreacy commented Oct 26, 2023

No description provided.

@rtreacy rtreacy converted this from a draft issue Oct 26, 2023
@bencomp
Copy link
Contributor

bencomp commented Oct 27, 2023

Oh, I missed a few of these in #9980! (#10054 is very similar)

Are you working on this already?

@qqmyers
Copy link
Member

qqmyers commented Oct 27, 2023

In general, issues still in the Dataverse_Global_Backlog board shouldn't be being worked on by anyone in the core team, so unless there's an assignment or chatter in the issue, I think you can consider it open.

@pdurbin
Copy link
Member

pdurbin commented Oct 27, 2023

Related:

This was referenced Oct 27, 2023
Closed
Merged
bencomp added a commit to bencomp/dataverse that referenced this issue Oct 27, 2023
@bencomp
Delegate JSON parsing from input streams and files
8cca389 
See IQSS#10056
@rtreacy
Copy link
Contributor Author

rtreacy commented Oct 27, 2023 •
edited
Loading

Every one of these you work on, let us know. We'll get them into ready for review and Jim can push them across the line. This is really critical IMHO

@bencomp
Copy link
Contributor

bencomp commented Oct 27, 2023

I just marked #10062 ready for review 😃

@github-project-automation github-project-automation bot moved this from SonarQube cleanup (Gustavo) to Clear of the Backlog in IQSS Dataverse Project Nov 13, 2023
@pdurbin pdurbin added this to the 6.1 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
IQSS Dataverse Project
Status: No status
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

Use JsonUtil.getJsonObject in AbstractApiBean, MakeDataCountApi bencomp/dataverse
4 participants
@pdurbin @rtreacy @bencomp @qqmyers