Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better organization to bundle properties #4825

Closed
pameyer opened this issue Jul 10, 2018 · 2 comments
Closed

better organization to bundle properties #4825

pameyer opened this issue Jul 10, 2018 · 2 comments
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF

Comments

@pameyer
Copy link
Contributor

pameyer commented Jul 10, 2018

Bundle.properties is ~2k lines of unstructured key/value pairs, comments and empty lines. With more information moving there, it may be worth investigating how to split this into several smaller property files according to functionality, or other potential approaches to reduce cognitive complexity.

@pdurbin
Copy link
Member

pdurbin commented Jul 10, 2018

@pameyer good idea. You'll be pleased to know that @JayanthyChengan has already begun the process of spitting up that giant Bundle.properties file into smaller files. She added ValidationMessages.properties in pull request #4815 for issue #3980.

@mheppler
Copy link
Contributor

mheppler commented Jul 10, 2018

Potentially duplicate of:

Related to:

@pdurbin pdurbin added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Oct 13, 2018
@pdurbin pdurbin added Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 7, 2023
@pdurbin pdurbin closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
None yet
Development

No branches or pull requests

3 participants