Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI language toggle to include country codes to support language locales #5046

Open
amberleahey opened this issue Sep 11, 2018 · 6 comments
Open
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Internationalization Type: Feature a feature request User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF

Comments

@amberleahey
Copy link

Related to #4685

Update from the community call today (09-11-2018), many people require having Dataverse in a specific language locale e.g. EN-CA, FR-FR, etc., and to be able to differentiate this in the UI toggle would be good. Please can we revisit the design of the UI toggle to incorporate these country/locales codes?

Someone mentioned using ISO country and language codes or some combination of plain language and code might be best. see: https://docs.oracle.com/cd/E13214_01/wli/docs92/xref/xqisocodes.html as example of codes to combine...

@oscardssmith
Copy link
Contributor

Probably should have considered this in original implementation. It would not be much harder to do (and still wouldn't). If you have some experience with Java this would actually be a pretty easy first pr. The changes would all be in one file.

@amberleahey
Copy link
Author

great, perhaps @JayanthyChengan can take a look!

@4tikhonov
Copy link
Contributor

I've just tested pre-release of 4.9.3 and it works fine. Just a question about translation of metadata fields still remain, how it will be handled in this release?

I see the extension of citation and metadata blocks with translated properties here:
https://github.com/scholarsportal/dataverse-property-files/blob/master/french/citation_fr.properties

Should this file should be merged with Bundle_fr.properties file (for French, in this specific example) or it will be separate support of files with properties for every discipline?

@4tikhonov
Copy link
Contributor

4tikhonov commented Sep 27, 2018

Update: I've managed to get all metadata fields translated (just modified 4 lines of source code) from merged Bundle_fr.properties file:
screen shot 2018-09-27 at 9 29 36 pm

I don't know if you guys will be interested in the solution as probably new release is already coming with the same functionality.

@pdurbin
Copy link
Member

pdurbin commented Sep 27, 2018

@4tikhonov that's awesome but #4684 is the issue about metadata fields so could you please post the screenshot over there? My understanding of this issue (#5046) is that it's about French in France vs French in Canada.

@pdurbin pdurbin added Type: Feature a feature request User Role: Guest Anyone using the system, even without an account Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 8, 2023
@cmbz
Copy link

cmbz commented Sep 16, 2024

2024/09/16: ABR review, @amberleahey please let us know if this is still a desired feature. If so, could you provide a bit more detail about the request? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Internationalization Type: Feature a feature request User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
None yet
Development

No branches or pull requests

5 participants