API: empty datasets can be created resulting in 502 errors

[MYF95]

Hi!

As written in the title, we can create "empty" datasets which in turn returns 502 when we try to access them via the dataverse page.

How to reproduce

The endpoint used is the one described here http://guides.dataverse.org/en/latest/api/native-api.html#id47

curl -H X-Dataverse-key:$dataverse-key-value https://demo.dataverse.org/api/dataverses/${dataverse}/datasets --upload-file example.json

The contents of example.json are as follows:

{
  "datasetVersion": {
    "metadataBlocks": {
      "citation": {
        "fields": [
        ]
      }
    }
  }
}

Which is the bare minimum amount of data allowed to create the dataset.

Current behaviour

This results in the following dataset being created:

And consequently when trying to enter the dataset page

Expected behaviour

Dataset is not created in the first place because the required minimum information is not there

or

The dataset page is able to load with no initial information (maybe using some default values if not set?)

We are not really actively using the endpoint, but just wanted to let you guys know since I found this when testing some of our endpoints using dataverse.

[djbrooke]

Thanks @MYF95 for the report. We'd want the behavior to be that the dataset would not be created.

[akio-sone]

Hi all, I guess this issue is related to #6739 (Multistore: If no files are uploaded to published dataset, export fails).

[djbrooke]

Thanks @akio-sone. @MYF95 and the team usually work against demo.dataverse.org, which is running 4.19 and does not have have the multiple stores changes. I think this is unrelated, but could be wrong.

[djbrooke]

• We'd want to not allow creation if the required fields are not passed and provide a message over the API.
• The solution here should include the validation and not just fail if it's empty (why doesn't the DB constraint get applied?)
• This may be just a Solr record being created
• We should make sure this condition cannot be achieved through editing as well

[poikilotherm]

I just came across this issue and I think this is (at least) related to my IQSS/dataverse-pm#26