-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GENERIC storage quota check to the file upload framework. #9361
Comments
We may want to consider adding a dedicated command for file creation. Otherwise, file uploads is one area/subsystem that's notoriously resource-intensive, but is completely outside the Command Engine framework and not traceable in the ActionLogRecord. |
…or the user on the upload page. #9361
grooming |
…ota is already full/exceeded. #9361
resolved onflicts: src/main/java/edu/harvard/iq/dataverse/util/FileUtil.java (#9361)
resolved conflicts (again): src/main/java/edu/harvard/iq/dataverse/util/FileUtil.java (#9361)
Resolved conflicts: src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java (#9361)
permissions lookup that allows it to be checked on either the Dataset or the parent Collection (when files are bing added in the context of creating a new dataset via the Add Dataset page). #9361
…nt exceeds the remaining quota; as opposed to accepting it zipped, even if the compressed size under the quota. #9361
…the uploaded files are saved (when uploading via the page) #9361
2023/09/11
|
2023/09/25: Added to 6.1 milestone as per conversation during prioritization meeting. |
Several issues have been opened for adding mechanisms for storage quotas. There is some overlap between them, but different kinds of quotas have been requested - per-user, per-dataset, per-collection, per-user-per-day. Some appear to be more urgent than the others. (case in point, the most recent one, #8549, opened by me, is a specific request from our curation team that we wanted to address soon).
(there may be a couple more that are complete duplicates of something requested by one or more of the issues above, those are omitted).
Each one of these issues does require the actual quota check to be present somewhere in the workflow of uploading and creating a file. So this new issue is just for adding that mechanism. Perhaps it can be tested against a single setting that defines the limit for ALL uploads, but once it's there it should be extendable to add more types of quota checks to satisfy the specific cases and scenarios requested in the issues above. It should be programmatically configurable, and it should be enforced everywhere where the application allows a creation of a new file - via the GUI, the API and in the direct upload workflow.
It can be as simple as slightly modifying the individual file size check that's already there; but it should probably be made more programmatic, etc.
The text was updated successfully, but these errors were encountered: