Update to Maven Docker Plugin 0.43.4 #9779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poikilotherm
added
the
Component: Containers
poikilotherm
changed the title
This comment has been minimized.
This comment has been minimized.
|
2023/09/18: Moved to Sprint Ready as per discussion in prioritization meeting. |
With this new version, a problem on M1 MACs not being able to build with Docker because of a non-existing config file was worked around by the DMP devs. See also: fabric8io/docker-maven-plugin#1678
pdurbin
force-pushed
the
9771-fix-docker-build
branch
from
198344a to
c93b180
Compare
pdurbin
approved these changes
Sep 26, 2023
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this new version, a problem on M1 MACs not being able to build with Docker because of a non-existing config file was worked around by the DMP devs.
Which issue(s) this PR closes:
Special notes for your reviewer:
There is a bug report that 0.43.2 was no longer allowing to push images. We'll see if this works again with this version.
Suggestions on how to test this:
@sekmiller is the one having the troubles. Hard to test.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: