-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set build number on beta war file #9815
Conversation
@pdurbin I have tested it by adding the step to the GitHub action in my fork repository. The new step is executed without errors: But when deploying the built artifact to Payara we encounter the following error: Job execution: https://github.com/GPortas/dataverse/actions/runs/5948494798/job/16132384602 On a second test, I deleted the step you added and executed the action again, obtaining the same error: https://github.com/GPortas/dataverse/actions/runs/5948579005 I'm going to approve the PR, since the error is not related to the action step you added, although we need to fix the error, since right now beta testing Dataverse service is not working: https://beta.dataverse.org |
Looking at the error, I would say that the Java Runtime Environment of the beta-testing instance has not been updated, making it incompatible with the latest versions of Dataverse, which require version 17. @donsizemore Any thoughts on this? |
So, after switching beta.dataverse.org to Java 17, deployment works and build info is displayed on the JSF UI: Job execution: https://github.com/GPortas/dataverse/actions/runs/5950689683/job/16139114289 Thanks for the help @donsizemore |
@GPortas perfect! Thanks for testing! (And @donsizemore thanks for upgrading to Java 17 on beta.) @scolapasta @kcondon this is very low risk if we'd like to merge it before 6.0 but it can also wait until after. |
Huh, merged but https://beta.dataverse.org/api/info/version still shows null for the build:
🤔 |
Oh, I guess it's because "deploy to payara" failed: https://github.com/IQSS/dataverse/actions/runs/6151994911/job/16693360612 |
What this PR does / why we need it:
It's nice to know what code is running on https://beta.dataverse.org
Which issue(s) this PR closes:
Special notes for your reviewer:
None.
Suggestions on how to test this:
Merge it and see it if works?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.