Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set build number on beta war file #9815

Merged
merged 2 commits into from
Sep 11, 2023
Merged

set build number on beta war file #9815

merged 2 commits into from
Sep 11, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Aug 22, 2023

What this PR does / why we need it:

It's nice to know what code is running on https://beta.dataverse.org

Which issue(s) this PR closes:

Special notes for your reviewer:

None.

Suggestions on how to test this:

Merge it and see it if works?

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@pdurbin pdurbin requested a review from GPortas August 22, 2023 18:40
@GPortas
Copy link
Contributor

GPortas commented Aug 23, 2023

@pdurbin I have tested it by adding the step to the GitHub action in my fork repository.

The new step is executed without errors:

buildnumber

But when deploying the built artifact to Payara we encounter the following error:

action_deploy_err

Job execution: https://github.com/GPortas/dataverse/actions/runs/5948494798/job/16132384602

On a second test, I deleted the step you added and executed the action again, obtaining the same error: https://github.com/GPortas/dataverse/actions/runs/5948579005

I'm going to approve the PR, since the error is not related to the action step you added, although we need to fix the error, since right now beta testing Dataverse service is not working: https://beta.dataverse.org

@GPortas
Copy link
Contributor

GPortas commented Aug 23, 2023

Looking at the error, I would say that the Java Runtime Environment of the beta-testing instance has not been updated, making it incompatible with the latest versions of Dataverse, which require version 17.

@donsizemore Any thoughts on this?

@GPortas
Copy link
Contributor

GPortas commented Aug 23, 2023

So, after switching beta.dataverse.org to Java 17, deployment works and build info is displayed on the JSF UI:

buildnumberui

Job execution: https://github.com/GPortas/dataverse/actions/runs/5950689683/job/16139114289

Thanks for the help @donsizemore

@pdurbin
Copy link
Member Author

pdurbin commented Aug 23, 2023

@GPortas perfect! Thanks for testing! (And @donsizemore thanks for upgrading to Java 17 on beta.)

@scolapasta @kcondon this is very low risk if we'd like to merge it before 6.0 but it can also wait until after.

@coveralls
Copy link

Coverage Status

coverage: 19.969%. remained the same when pulling 2a463b0 on 9814-beta-commit into 62a9811 on develop.

@kcondon kcondon self-assigned this Sep 11, 2023
@kcondon kcondon merged commit a16f86f into develop Sep 11, 2023
9 checks passed
@kcondon kcondon deleted the 9814-beta-commit branch September 11, 2023 21:31
@pdurbin
Copy link
Member Author

pdurbin commented Sep 12, 2023

Huh, merged but https://beta.dataverse.org/api/info/version still shows null for the build:

{"status":"OK","data":{"version":"6.0","build":null}}

🤔

@pdurbin pdurbin added this to the 6.1 milestone Sep 12, 2023
@pdurbin
Copy link
Member Author

pdurbin commented Sep 12, 2023

Oh, I guess it's because "deploy to payara" failed: https://github.com/IQSS/dataverse/actions/runs/6151994911/job/16693360612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beta server doesn't show commit in /api/info/version
4 participants