Add Markdown previewer in Guide #9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-loop-1
changed the title
pdurbin
reviewed
Oct 9, 2023
There was a problem hiding this comment.
@mr-loop-1 thanks for the pull request! 🎉 ❤️
I added a release note. I think I forgot to mention that, sorry. That process is at https://guides.dataverse.org/en/6.0/developers/making-releases.html#write-release-notes and there's an open issue for that too, if you're interested in making another PR:
I'm leaving a couple ```suggestion comments. You can just click them and it will make the change automatically. Thanks!
doc/sphinx-guides/source/_static/admin/dataverse-external-tools.tsv
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Durbin <[email protected]>
Co-authored-by: Philip Durbin <[email protected]>
|
Thanks a lot @pdurbin , |
pdurbin
added
the
hacktoberfest-accepted
|
@mr-loop-1 looks great! I'll talk about it during standup tomorrow (11am Eastern) and approve it then. Thanks! |
pdurbin
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The guide needs to be updated for new addition of markdown previewer in list of file previewers and external tools.
Which issue(s) this PR closes:
Special notes for your reviewer: Added markdown after pdf based on probable frequency among types
Suggestions on how to test this: NA
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: No