Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful fail for downloading oxcal requested #43

Open
MartinHinz opened this issue Jul 2, 2021 · 6 comments
Open

Graceful fail for downloading oxcal requested #43

MartinHinz opened this issue Jul 2, 2021 · 6 comments

Comments

@MartinHinz
Copy link
Member

Prof. Brian Ripley wrote 28th of June 2021:

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_oxcAAR.html.

Please correct before 2021-07-12 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

@MartinHinz
Copy link
Member Author

implemented desired behavior in Branch quickfix_download_and_cran_checks with 1ee51c2 and 3cd31e0. Next steps: CRAN re-release: suggested name: Karpo.

@MartinHinz
Copy link
Member Author

Remerge into master is requested after review.

@MartinHinz
Copy link
Member Author

MartinHinz commented Jul 2, 2021

After that: Check for release/resubmit:

  • The package works and all functions are usable
  • The package documentation is up-to-date and represents the functions correctly
  • The test coverage of the package functions is sufficient
  • DESCRIPTION is up-to-date with the latest version number and database list
  • README.md is up-to-date
  • NEWS.md is up-to-date and includes the latest changes
  • Package checks ran and did not yield any ERRORS, WARNINGS or NOTES (or at least the NOTES are addressed in the cran-comments.md)
    • locally (devtools::check())
    • rhub (devtools::check_rhub(email = ...))
    • winbuilder (devtools::check_win_release(email = ....) + devtools::check_win_devel(email = ....))
  • Spellcheck with devtools::spell_check() ran and did yield not only false-positives
  • codemeta.json is up-to-date (can be updated with codemetar::write_codemeta())
  • inst/CITATION is up-to-date
  • The package does not make external changes without explicit user permission. It does not write to the file system, change options, install packages, quit R, send information over the internet, open external software, etc.
  • No reverse dependencies break because of the new package version (devtools::revdep_check())

@MartinHinz
Copy link
Member Author

PR #44 Remerged into master, now prerelease-check.

@MartinHinz
Copy link
Member Author

All resubmit checks passed, PR prerelease branch into master

@MartinHinz
Copy link
Member Author

merged #45 into master. Initiating devtools::release().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant