Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] blocks(::PermutedDimsArray) should return NestedPermutedDimsArray #17

Open
mtfishman opened this issue Dec 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mtfishman
Copy link
Member

mtfishman commented Dec 17, 2024

Redesign blocks(::PermutedDimsArray) so that it returns a NestedPermutedDimsArray.

@mtfishman mtfishman added the enhancement New feature or request label Dec 17, 2024
@mtfishman
Copy link
Member Author

Note that that NestedPermutedDimsArray will have to be added as a supported wrapper of SparseArraysBase.AbstractSparseArray. That should be done through a package extension of SparseArraysBase.jl. The logic for overloading the SparseArraysBase.jl interface for Base wrappers is here: https://github.com/ITensor/SparseArraysBase.jl/blob/c67b83a1348d74a6e6bdafa977740e923da0dd6e/src/wrappers.jl. Ideally that code would be made extensible by defining something like a WrappedAbstractSparseArrayInterface in the style of Derive.jl, so then it would only require a few overloads and all of the functionality of SparseArraysBase.jl can be derived for the new NestedPermutedDimsArray wrapper. One subtle part with that plan that we'll have to work out is making sure that NestedPermutedDimsArray can interoperate with other wrapper types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant