From a4c6e7496353b75f081754956f9491aa365fce25 Mon Sep 17 00:00:00 2001 From: Joseph Tindall Date: Wed, 18 Oct 2023 10:26:32 -0400 Subject: [PATCH] Certain kwargs -> Function signature in factorize_svd --- src/tensor_operations/matrix_decomposition.jl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/tensor_operations/matrix_decomposition.jl b/src/tensor_operations/matrix_decomposition.jl index d5975d893e..6cbf7fff37 100644 --- a/src/tensor_operations/matrix_decomposition.jl +++ b/src/tensor_operations/matrix_decomposition.jl @@ -550,10 +550,15 @@ function sqrt_decomp(D::ITensor, u::Index, v::Index) return sqrtDL, prime(δᵤᵥ), sqrtDR end -function factorize_svd(A::ITensor, Linds...; (singular_values!)=nothing, kwargs...) - ortho::String = get(kwargs, :ortho, "left") - alg::String = get(kwargs, :svd_alg, "divide_and_conquer") - dir = get(kwargs, :dir, ITensors.In) +function factorize_svd( + A::ITensor, + Linds...; + (singular_values!)=nothing, + ortho="left", + alg="divide_and_conquer", + dir=ITensors.In, + kwargs..., +) leftdir, rightdir = -dir, -dir USV = svd(A, Linds...; leftdir, rightdir, kwargs..., alg=alg)