Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for determining AbstractNamedDimsArray type from dimension names #11

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

mtfishman
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.32%. Comparing base (b21c44e) to head (3081540).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/abstractnameddimsarray.jl 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   33.56%   34.32%   +0.75%     
==========================================
  Files          14       14              
  Lines         566      574       +8     
==========================================
+ Hits          190      197       +7     
- Misses        376      377       +1     
Flag Coverage Δ
docs 34.20% <77.77%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title Improve logic for determining NamedDimsArray type from dimension name type Improve logic for determining AbstractNamedDimsArray type from dimension name type Jan 5, 2025
@mtfishman mtfishman changed the title Improve logic for determining AbstractNamedDimsArray type from dimension name type Improve logic for determining AbstractNamedDimsArray type from dimension names Jan 5, 2025
@mtfishman mtfishman merged commit 6c2e1b2 into main Jan 5, 2025
12 checks passed
@mtfishman mtfishman deleted the nameddimsarraytype branch January 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant